Don't split creation of deprecation message and choice of warning class. #12995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids duplicating the
```
category = (PendingDeprecationWarning if pending
else MatplotlibDeprecationWarning)
```
logic; right now it's only present twice which is not too bad, but I
plan to add another deprecator (for function arguments) so this is
preliminary work for it.
timhoffm
reviewed
Dec 15, 2018
| @@ -34,7 +34,7 @@ def _generate_deprecation_message( | ||
|
|
||
| if not message: | ||
| message = ( | ||
| "The %(name)s %(obj_type)s" | ||
| "\nThe %(name)s %(obj_type)s" |
There was a problem hiding this comment.
IIRC we had a discussion some time ago that we do not want warnings and logs to introduce newlines.
There was a problem hiding this comment.
I didn't want one and still don't, but @dstansby argued in favor of it so there's one right now in warn_deprecated (so I put one here as well) but none in deprecated. I decided to leave it in as I don't care enough to argue about that, but either way it should be consistent between the two cases.
6 tasks
timhoffm
approved these changes
Dec 16, 2018
dstansby
approved these changes
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids duplicating the
logic; right now it's only present twice which is not too bad, but I
plan to add another deprecator (for function arguments) so this is
preliminary work for it.
PR Summary
PR Checklist