FIX: skip gtk backend if gobject but not pygtk is installed #12929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to install gobject (which provides `gi`) but not pygtk (which provide the `GTK` bindings). This try-except converts the ValueError that gi raises to an ImportError so our machinery works correctly.
|
marking to backport as this fixes a failure-to-import bug. |
timhoffm
approved these changes
Dec 4, 2018
| @@ -40,7 +40,15 @@ | ||
|
|
||
| if gi.__name__ == "pgi" and gi.version_info < (0, 0, 11, 2): | ||
| raise ImportError("The GTK3 backends are incompatible with pgi<0.0.11.2") | ||
| gi.require_version("Gtk", "3.0") | ||
| try: | ||
| # :raises ValueError: If module/version is already loaded, already |
There was a problem hiding this comment.
Not shure what the leading colon is for, but heh.
There was a problem hiding this comment.
I just copy-pasted their docstring (which uses the google style docstrings)
anntzer
approved these changes
Dec 10, 2018
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 10, 2018
…t pygtk is installed
QuLogic
added a commit
that referenced
this pull request
Dec 10, 2018
…929-on-v3.0.x Backport PR #12929 on branch v3.0.x (FIX: skip gtk backend if gobject but not pygtk is installed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to install gobject (which provides
gi) but notpygtk (which provide the
GTKbindings). This try-except convertsthe ValueError that gi raises to an ImportError so our machinery works
correctly.