Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Cleanup axes/_base.py. #12855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2018
Merged

Cleanup axes/_base.py. #12855

merged 1 commit into from
Nov 23, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 20, 2018

  • Axes.pick should just be directly inherited from Artist.
  • Tweaking get_children just a bit avoids having to override it in
    Axes3D.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Nov 20, 2018
@anntzer
Cleanup axes/_base.py.
b72518a 
- `Axes.pick` should just be directly inherited from Artist.
- Tweaking get_children just a bit avoids having to override it in
  Axes3D.
timhoffm
timhoffm approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the order of the children in Axes3D.get_children. But it's now more consistent to have all the axes together. Hopefully, nobody is relying on the order.

@jklymak jklymak merged commit a9d4ccc into matplotlib:master Nov 23, 2018
@anntzer anntzer deleted the cleanup branch November 24, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.