Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Use skipif, not xfail, for uncomparable image formats. #12746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2018
Merged

Use skipif, not xfail, for uncomparable image formats. #12746

merged 1 commit into from
Nov 5, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 5, 2018

PR Summary

Essentially the same rationale as #11701.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Nov 5, 2018
@anntzer anntzer force-pushed the imagecomparisonskipif branch from 12ca07d to 224352a Compare November 5, 2018 12:42
@jklymak jklymak merged commit 8f969d1 into matplotlib:master Nov 5, 2018
@anntzer anntzer deleted the imagecomparisonskipif branch November 6, 2018 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.