Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@ImportanceOfBeingErnest
Copy link
Member

@ImportanceOfBeingErnest ImportanceOfBeingErnest commented Sep 27, 2018

PR Summary

In #11989 the required version of ghostscript was changed to be >= 9.0.
This is currently not reflected in parts of the code and the docs.

This PR updates the code and docs where appropriate to make this requirement visible.

It thereby provides an answer to the question raised a year ago

Is the minimal gs version in the docs anyplace that also needs to be update?

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@ImportanceOfBeingErnest ImportanceOfBeingErnest added this to the v3.0.x milestone Sep 27, 2018
@tacaswell tacaswell merged commit dd2900b into matplotlib:master Sep 27, 2018
@tacaswell
Copy link
Member

Thanks @ImportanceOfBeingErnest !

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 27, 2018

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 dd2900be4e15a3a12ffe4dab058373f5656f6f90
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #12301: Ghostscript 9.0 requirement revisited'
  1. Push to a named branch :
git push YOURFORK v3.0.x:auto-backport-of-pr-12301-on-v3.0.x
  1. Create a PR against branch v3.0.x, I would have named this PR:

"Backport PR #12301 on branch v3.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.