Deprecate the tk_window_focus function. #11884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Aug 19, 2018
lib/matplotlib/__init__.py
Outdated
| @@ -1379,6 +1379,7 @@ def is_interactive(): | ||
| return rcParams['interactive'] | ||
|
|
||
|
|
||
| @cbook.deprecated("3.1") |
There was a problem hiding this comment.
Should it get an alternate="rcParams['tk.window_focus']"
The tk backend has been reading directly from rcParams["tk.window_focus"] since 17e6145 (2005), and the function is unused since then.
b508931 to
72d2384
Compare
jklymak
approved these changes
Aug 19, 2018
timhoffm
approved these changes
Aug 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tk backend has been reading directly from
rcParams["tk.window_focus"] since 17e6145 (2005), and the function is
unused since then.
PR Summary
PR Checklist