facecolor stale missing #11824
Merged
facecolor stale missing #11824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Aug 8, 2018
|
If you noticed this, that means your are using |
|
Do we have a way to test stale-related things? Also, should this be back-ported? |
|
There are some tests, but not exhaustive. I am 50/50 on backporting this (it is a bug from the original implementation for iirc 1.4) |
dstansby
approved these changes
Aug 9, 2018
|
Merged with backport. Can revert backport if we think its a mistake, but I don't see the harm in making this work... |
tacaswell
added a commit
that referenced
this pull request
Aug 9, 2018
…824-on-v2.2.x Backport PR #11824 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axes.facecolordoesn't update the figure in interactive mode.I added the line
self.stale = Truethat fix that.