Start work on making colormaps picklable. #11723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jul 21, 2018
lib/matplotlib/cm.py
Outdated
| return f(1 - x) | ||
| return freversed | ||
| def _reverser(f, x=None): | ||
| if x is None: |
There was a problem hiding this comment.
This could use a short explanation even if it's private. Something like
Return a function f' for a given function f such that f'(x) = f(1-x).
Usage: ``_reverser(f)``. The parameter *x* is only used internally.
Maybe also use _x instead of x.
There was a problem hiding this comment.
Added docstring; left x as such as that's also how it appears in the signature of the partial object.
dstansby
approved these changes
Jul 21, 2018
jklymak
reviewed
Jul 21, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
See discussion in #11716.
Mostly putting this up as an example of how to exploit functools.partial to keep things picklable.
(pycodestyle doesn't like this but I think this should rather be fixed with an exemption, see also PyCQA/pycodestyle#231.)
PR Checklist