Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

TESTS: Increase tolerance for aarch64 tests #11666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2018

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Jul 15, 2018

PR Summary

Tests had been failing on aarch64 machines due to human-imperceptible differences (antialiasing, perhaps, floating point rounding, perhaps). This PR adds a small pad to tests which failed, only for platform.machine() == 'aarch64'.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) (N/A)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.1 milestone Jul 17, 2018
@jklymak jklymak merged commit d99722e into matplotlib:master Jul 17, 2018
@tacaswell tacaswell modified the milestones: v3.1, v3.0 Jul 17, 2018
@ksunden ksunden deleted the aarch64_tests branch November 19, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.