Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Cleanup stix_fonts_demo example. #11571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 4, 2018

  • The s variable conditionally defined was never used.
  • The '--latex' in sys.argv branch (which dates back to the origin of
    the example, a567601), likely never worked (\mathbb requires
    \usepackage{amsfonts}), so just kill it.
  • Saving the figure doesn't really help with the example and tends to
    clutter the source tree when running the example, so don't do it.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

- The `s` variable conditionally defined was never used.
- The `'--latex' in sys.argv` branch (which dates back to the origin of
  the example, a567601), likely never worked (\mathbb requires
  \usepackage{amsfonts}), so just kill it.
- Saving the figure doesn't really help with the example and tends to
  clutter the source tree when running the example, so don't do it.
@jklymak jklymak merged commit 7e8acec into matplotlib:master Jul 4, 2018
@QuLogic QuLogic added this to the v3.0 milestone Jul 5, 2018
@anntzer anntzer deleted the stixfonts branch July 5, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.