Use explicit signature in pyplot.close() #11563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Jul 3, 2018
lib/matplotlib/pyplot.py
Outdated
| """ | ||
|
|
||
| if len(args) == 0: | ||
| if fig is not None: |
e782b23 to
31f4471
Compare
anntzer
reviewed
Jul 3, 2018
lib/matplotlib/pyplot.py
Outdated
| else: | ||
| raise TypeError('close takes 0 or 1 arguments') | ||
| raise TypeError('Unrecognized argument type %s to close' % type(fig)) |
There was a problem hiding this comment.
argument of type
or see how e.g. int does it:
----> 1 int([])
TypeError: int() argument must be a string, a bytes-like object or a number, not 'list'
31f4471 to
f6bdcb5
Compare
|
👍 , but I am concerned about the drop in the coverage on the tests. Historically that has not had many false-positives. |
|
I don't really understand how codecov generates its numbers. Out of the two branches, two are not hit: the UUID und the TypeError. The coverage for pyplot has actually increased. For some reason there are other changes as well in the codecov report, which are not part of the PR. |
jklymak
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Use explicit argument in
pyplot.close()instead of*args. The signature gets more explicit and the code gets shorter.The behavior of the code stays exactly the same (apart from a different message in the TypeError if more than one parameter is passed).