Fix infinite loop for connectionstyle + add some tests #11323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2018
9c50031 to
4cea630
Compare
4cea630 to
d0e6be0
Compare
WeatherGod
approved these changes
May 28, 2018
jklymak
approved these changes
May 28, 2018
| @@ -31,8 +31,9 @@ def get_intersection(cx1, cy1, cos_t1, sin_t1, | ||
| c, d = sin_t2, -cos_t2 | ||
|
|
||
| ad_bc = a * d - b * c | ||
| if ad_bc == 0.: | ||
| raise ValueError("Given lines do not intersect") | ||
| if np.abs(ad_bc) < 1.0e-12: |
There was a problem hiding this comment.
There was a problem hiding this comment.
What's the difference between
np.abs(ad_bc) < 1.0e-12np.isclose([0], [ad_bc], atol=1.0e-12)
Why would I prefer the longer over the shorter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #11294.
A comparrisson with 0 (
x == 0) is replaced by comparing with a small number (abs(x) < eps) such that numeric errors do not bypass the raising of an error for non-intersecting lines.Related to that, commit #9519 intended to add a test for ConnectionStyles which was hindered by errors as seen in #9518. This PR adds the desired test by choosing an arrow style, which allows for all ConnectionStyles to be tested. Hence fixes #9518.
PR Checklist