py3fication of some tests. #11073
Merged
py3fication of some tests. #11073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobson
approved these changes
Apr 18, 2018
dstansby
reviewed
Apr 18, 2018
| filename = os.path.join( | ||
| os.path.dirname(__file__), | ||
| 'baseline_images', 'dviread', 'test.map') | ||
| filename = str(Path(__file__).parent / 'baseline_images/dviread/test.map') |
There was a problem hiding this comment.
Shouldn't 'baseline_images/dviread/test.map' still be created with os.path.join?
There was a problem hiding this comment.
no, pathlib handles these internally just fine (see e.g. third example of https://docs.python.org/3/library/pathlib.html#operators).
dstansby
approved these changes
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Also includes #5858 (comment).
PR Checklist