Remove setup_tests_only.py. #11055
Merged
Remove setup_tests_only.py. #11055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That file was added in 42fa2b6 without comment as to why (and renamed in ab99e65 to avoid confusing pytest); calling `python setup_test_only.py sdist` (which I guess is the only reasonable thing to do with it -- it's distutils so you can't even build a wheel out of it) doesn't create a correct "tests-only" sdist either.
dstansby
approved these changes
Apr 16, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That file was added in 42fa2b6 without comment as to why (and renamed in ab99e65 to avoid confusing pytest); calling
python setup_test_only.py sdist(which I guess is the only reasonable thing to do with it -- it's distutils so you can't even build a wheel out of it) doesn't create a correct "tests-only" sdist either.PR Summary
PR Checklist