Remove some wx version checks. #10636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad5dcc8 to
5ee2afa
Compare
|
That presumably also means that is_phoenix will always evaluate to True as phoenix is the codename for wx 4.x which should allow significantly more code to be deleted. |
|
yup, but that'll be another PR. |
|
Ok sure but then your title is slightly misleading ;) you are only dropping part of the version checks. |
timhoffm
approved these changes
Mar 3, 2018
jklymak
approved these changes
Mar 6, 2018
mpl3 wx supports any wxpython that does support Py3 (i.e., wwpython>=4), so we can drop the version checks.
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpl3 wx supports any wxpython that does support Py3 (i.e., wwpython>=4),
so we can drop the version checks.
PR Summary
PR Checklist