Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove unused private _StringFuncParser. #10524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 18, 2018

PR Summary

StringFuncParser was originally added to support the FuncNorm and PiecewiseNorm classes that were proposed in #7294, but the agreement from multiple core devs in that PR and other linked sub-PRs is that even if the classes themselves may be revisited, the string spec of functions was not a good idea. So the parser can be removed.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.0 milestone Feb 18, 2018
@efiring efiring merged commit fbc6983 into matplotlib:master Feb 19, 2018
@anntzer anntzer deleted the remove-stringfuncparser branch February 19, 2018 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.