-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: deprecate qt4/5 rcparams #10351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: deprecate qt4/5 rcparams #10351
Conversation
Note that matplotlib/tutorials/introductory/usage.py Line 495 in 482bde0
|
Milestoning as release critical if #10282 is going to stay in... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a much better way to do it indeed.
Failures:
|
047aa18
to
17112e8
Compare
Sorry - shouldn't ask for reviews before I make sure the tests pass. |
@anntzer does this mean we can remove the somewhat complicated testing check? I left it in for now... |
Probably the warnings suppression in |
I didn't see what needs changing in |
I guess I wasn't saying we had to get rid of all the warning suppression. I don't quite understand what those two sections do. Feel free to push onto this PR, or open one and close thsi one. |
Leaving them in is a bit redundant but not a critical problem I think. |
Isn't this still happening on the Python 3.6 build? Sure is annoying when running pytest. |
I’m a little confused about pytest. Does it look at the local matplotlibrc? If so, if you still have that rcParams in your matplotlibrc you’ll get the warnings. |
Test setup calls |
Ok well we should put the test logic back then I guess. I do t quite get why this is happening though. |
Won't have much time to take care of this (or other prs) in the coming days. Will get back later, but if this is blocking a release feel free to revert the original deprecation (sorry for the sloppy patch). |
OK, |
PR Summary
#10282 deprecated rcparams
backend.qt4
andbackend.qt5
but left the defaults active so the deprecation warning came on, even if the user did not have these rcparams in thematplotlibrc
. This PR makes the defaultsNone
, and adds a check forNone
in the validator (that returns the old defaults). Hence the deprecation now only displays if these rcParams are still in thematplotlibrc
.PR Checklist