Join strings instead of adding them. #10332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
approved these changes
Jan 27, 2018
QuLogic
approved these changes
Jan 27, 2018
|
That is exciting that we do not run any of those lines of code in the test suite! |
timhoffm
requested changes
Jan 27, 2018
| writeln(self.fh, | ||
| r"\pgfsetdash{" | ||
| + "".join(r"{%fpt}" % dash for dash in dash_list) | ||
| + "r}{%fpt}" % dash_offset) |
There was a problem hiding this comment.
588: "r: The r was a raw string qualifier before and seems to have slipped into the string.
There was a problem hiding this comment.
cf @tacaswell's comment about none of this being tested :p
fixed
timhoffm
reviewed
Jan 28, 2018
| dash_str += r"{%fpt}" % dash | ||
| dash_str += r"}{%fpt}" % dash_offset | ||
| writeln(self.fh, dash_str) | ||
| writeln(self.fh, |
There was a problem hiding this comment.
On the danger of being pedantic, I would simply write
dash_pattern = "".join(r"{%fpt}" % dash for dash in dash_list)
writeln(self.fh,
r"\pgfsetdash{%s}{%fpt}" % (dash_pattern, dash_offset))
timhoffm
approved these changes
Jan 28, 2018
See e.g. https://docs.python.org/3/library/functions.html#sum that documents "".join as the preferred method (briefly, because summing (or repeated addition) has quadratic complexity for strings).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See e.g. https://docs.python.org/3/library/functions.html#sum that
documents "".join as the preferred method (briefly, because summing (or
repeated addition) has quadratic complexity for strings).
side note:
https://github.com/takluyver/astsearch and https://github.com/hchasestevens/astpath are quite nice for this kind of cleanups...
PR Summary
PR Checklist