Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Make commented ACCEPTS statements inline comments #10313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

timhoffm
Copy link
Member

PR Summary

Docstring cleanup:
Following #10284 this PR changes ACCEPTS from comment blocks to inline comments.

@@ -902,8 +901,7 @@ def set_axes_locator(self, locator):
"""
Set the axes locator.

..
ACCEPTS: a callable object which takes an axes instance and
.. ACCEPTS: a callable object which takes an axes instance and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realign?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -1342,8 +1339,7 @@ def set_adjustable(self, adjustable):
unintended side effect. For cases when sharing axes is
fine, use 'box-forced'.

..
ACCEPTS: [ 'box' | 'datalim' | 'box-forced']
.. ACCEPTS: [ 'box' | 'datalim' | 'box-forced']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before bracket

Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only minor nonblocking points

@jklymak jklymak added this to the v2.2 milestone Jan 24, 2018
@jklymak jklymak merged commit 61085e1 into matplotlib:master Jan 25, 2018
@timhoffm timhoffm deleted the inline-accepts branch January 25, 2018 23:15
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.