FIX: don't autorotate xpdf images #10294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Jan 23, 2018
| @@ -1557,12 +1557,14 @@ def xpdf_distill(tmpfile, eps=False, ptype='letter', bbox=None, rotated=False): | ||
| command = [str("ps2pdf"), "-dAutoFilterColorImages#false", | ||
| "-dAutoFilterGrayImages#false", | ||
| "-sGrayImageFilter#FlateEncode", | ||
| "-dAutoRotatePages=false", |
There was a problem hiding this comment.
needs a hash to make windows happy... (see above too)
unfortunately we're not currently testing this codepath on windows CI
anntzer
reviewed
Jan 23, 2018
| @@ -1544,7 +1544,7 @@ def xpdf_distill(tmpfile, eps=False, ptype='letter', bbox=None, rotated=False): | ||
| """ | ||
| pdffile = tmpfile + '.pdf' | ||
| psfile = tmpfile + '.ps' | ||
|
|
||
6 tasks
|
Closing in lieu of #10295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As per #10290, ghostscript auto-rotates during
ps2pdf, so if a figure has a lot of roated text it gets unexpectedly rotated if the user hasrcParams['ps.usedistiller'] = "xpdf"set.This passes the flag "-dAutoRotatePages=false" to
ps2pdf.See also
https://www.ghostscript.com/doc/current/Ps2pdf.htm
PR Checklist