Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

2.1.0 sdist does not allow building docs #9735

Copy link
Copy link
Closed
@anntzer

Description

@anntzer
Issue body actions

See issue described at https://mail.python.org/pipermail//matplotlib-devel/2017-November/000895.html

This is due (at least) to an outdated MANIFEST.in (which is missing, for example, INSTALL.rst).

Instead of continually trying to keep MANIFEST.in in sync with the source tree (a never ending task...) I propose to make it include everything, but hook the sdist command to first check that we are in a clean git repo (and ask the user to run git clean -xdf if in a dirty repo, and accept not being able to build an sdist from a non-repo (not sure what the use case is tbh...)).

Or perhaps we can even completely subvert setup.py sdist to run git archive $tag -o dist/matplotlib-$version.tgz --prefix matplotlib-$version.tgz which actually appears to also creates a valid(?) sdist that pip can install (and we can set export-ignore if there are files we don't want to include, see https://git-scm.com/docs/git-archive#ATTRIBUTES).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.