Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MEP22 method names #17987

Copy link
Copy link
Open
Open
Copy link
@anntzer

Description

@anntzer
Issue body actions

A small point re: MEP22 API design: having both ToolManager.add_tool and ToolContainerBase.add_tool as user-facing APIs (see e.g. toolmanager_sgskip.py) is slightly awkward, given that they actually have different signatures and do different things.

(I guess one could even ask whether the ToolManager and ToolContainer actually need to exist as separate objects -- a single ToolManager/Container object could e.g. hold the GUI toolbar widget as attribute instead of inheriting from it, for example. This would perhaps also avoid the slight inconsistency that adding a tool to the toolbar needs two calls (add_tool both on the manager and the container), whereas removing it only needs ont (remove_tool on the container); again, see toolmanager_sgskip.py).

Metadata

Metadata

Assignees

No one assigned

    Labels

    MEP: MEP22tool managertool managerkeepItems to be ignored by the “Stale” Github ActionItems to be ignored by the “Stale” Github Action

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.