Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Expose internal animation parameters #17928

Copy link
Copy link
Open
@story645

Description

@story645
Issue body actions

To follow up on this, the current call to HTMLWriter only passes three arguments:

writer = HTMLWriter(fps=fps,
embed_frames=embed_frames,
default_mode=default_mode)

but there are several more parameters that it could set:

def __init__(self, fps=30, codec=None, bitrate=None, extra_args=None,
metadata=None, embed_frames=False, default_mode='loop',
embed_limit=None):

So we could thread through the frame_format parameter in this PR, but I think it might be better handled in a separate PR that focuses entirely on exposing internal animation parameters. This I think is independent of the issue in this thread, where the rcParams does not allow us to set a default at all currently. Fixing the rcparams check (#17909 ) seems necessary to me, exposing more API seems nice-to-have.

Originally posted by @bmcfee in #17908 (comment)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.