Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add pull request checklist to Reviewers Guidelines #15280

Copy link
Copy link
Closed
@story645

Description

@story645
Issue body actions

In the Reviewers Guideline, there's a section called Pull Request Checklist tthat doesn't have a checklist. What about adding one in that section as a sort of intro/framing/table of contents for the rest of the page?

The jumping off point could be the checklist @timhoffm so helpfully provided:

Nevertheless, here's a condensed checklist of the thing to check before merging:

  • Check that the PR targets the master branch
  • Check/set labels
  • Check/set milestone
  • Check that tests still pass
  • Check that the PR does not have excessive commits. One or a few semantically grouped commits should do (in particular less experienced github users tend to commit all their changes in sequence). If there are too many, ask the author to squash, or use "Squash and Merge" button in the github UI.

Originally posted by @timhoffm in #15252 (comment)

Yes, should probably just put in this PR, writing it up as an issue so that I don't forget and it's out there for anybody to do.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.