Closed
Description
In the Reviewers Guideline, there's a section called Pull Request Checklist tthat doesn't have a checklist. What about adding one in that section as a sort of intro/framing/table of contents for the rest of the page?
The jumping off point could be the checklist @timhoffm so helpfully provided:
Nevertheless, here's a condensed checklist of the thing to check before merging:
- Check that the PR targets the master branch
- Check/set labels
- Check/set milestone
- Check that tests still pass
- Check that the PR does not have excessive commits. One or a few semantically grouped commits should do (in particular less experienced github users tend to commit all their changes in sequence). If there are too many, ask the author to squash, or use "Squash and Merge" button in the github UI.
Originally posted by @timhoffm in #15252 (comment)
Yes, should probably just put in this PR, writing it up as an issue so that I don't forget and it's out there for anybody to do.