Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f791518

Browse filesBrowse files
authored
Merge pull request #23634 from QuLogic/make-opts
make.bat: Don't override SPHINXOPTS/O from the environment
2 parents a0f16a8 + 6840108 commit f791518
Copy full SHA for f791518

File tree

Expand file treeCollapse file tree

2 files changed

+5
-11
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-11
lines changed

‎doc/devel/documenting_mpl.rst

Copy file name to clipboardExpand all lines: doc/devel/documenting_mpl.rst
+2-9Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,6 @@ it, use
8282
8383
make SPHINXOPTS= html
8484
85-
On Windows the arguments must be at the end of the statement:
86-
87-
.. code-block:: bat
88-
89-
make html SPHINXOPTS=
90-
9185
You can use the ``O`` variable to set additional options:
9286

9387
* ``make O=-j4 html`` runs a parallel build with 4 processes.
@@ -97,12 +91,11 @@ You can use the ``O`` variable to set additional options:
9791
Multiple options can be combined using e.g. ``make O='-j4 -Dplot_gallery=0'
9892
html``.
9993

100-
On Windows, either put the arguments at the end of the statement or set the options as environment variables, e.g.:
94+
On Windows, set the options as environment variables, e.g.:
10195

10296
.. code-block:: bat
10397
104-
set O=-W --keep-going -j4
105-
make html
98+
set SPHINXOPTS= & set O=-j4 -Dplot_gallery=0 & make html
10699
107100
Showing locally built docs
108101
--------------------------

‎doc/make.bat

Copy file name to clipboardExpand all lines: doc/make.bat
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ if "%SPHINXBUILD%" == "" (
1010
set SOURCEDIR=.
1111
set BUILDDIR=build
1212
set SPHINXPROJ=matplotlib
13-
set SPHINXOPTS=-W
14-
set O=
13+
if defined SPHINXOPTS goto skipopts
14+
set SPHINXOPTS=-W --keep-going
15+
:skipopts
1516

1617
%SPHINXBUILD% >NUL 2>NUL
1718
if errorlevel 9009 (

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.