Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f6f9c8c

Browse filesBrowse files
committed
DOC: add review guidelines
Documenting the status-quo
1 parent 2fe9e32 commit f6f9c8c
Copy full SHA for f6f9c8c

File tree

Expand file treeCollapse file tree

1 file changed

+18
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+18
-0
lines changed

‎doc/devel/coding_guide.rst

Copy file name to clipboardExpand all lines: doc/devel/coding_guide.rst
+18Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,24 @@ C/C++ extensions
165165

166166

167167

168+
PR Review guidelines
169+
====================
170+
171+
* We run on a 'use your judgement' system (for better or worse) and do
172+
not have a strict nose-count rule. If you have a commit bit, then
173+
you are trusted to use it and to know when to ask for more review.
174+
175+
* Do not self merge with the exception of un-breaking travis.
176+
177+
* Squashing is case-by-case. The balance is between burden on the
178+
contributor, keeping a relatively clean history, and keeping a
179+
history usable for bisecting. The only time we are really strict
180+
about it is to eliminate binary files (ex multiple test image
181+
re-generations) and to remove upstream merges.
182+
183+
* Be patient with new contributors.
184+
185+
168186
Style guide
169187
===========
170188

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.