Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e0b6525

Browse filesBrowse files
committed
Make the Qt interactive zoom rectangle black & white.
Explicitly drawing white segments makes it visible even over dark backgrounds.
1 parent bd1e75a commit e0b6525
Copy full SHA for e0b6525

File tree

Expand file treeCollapse file tree

2 files changed

+12
-3
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+12
-3
lines changed
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Qt zoom rectangle now black and white
2+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3+
4+
This makes it visible even over a dark background.

‎lib/matplotlib/backends/backend_qt5.py

Copy file name to clipboardExpand all lines: lib/matplotlib/backends/backend_qt5.py
+8-3Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -479,10 +479,15 @@ def drawRectangle(self, rect):
479479
# to be called at the end of paintEvent.
480480
if rect is not None:
481481
def _draw_rect_callback(painter):
482-
pen = QtGui.QPen(QtCore.Qt.black, 1 / self._dpi_ratio,
483-
QtCore.Qt.DotLine)
482+
scaled_rect = [pt / self._dpi_ratio for pt in rect]
483+
pen = QtGui.QPen(QtCore.Qt.black, 1 / self._dpi_ratio)
484+
pen.setDashPattern([3, 3])
484485
painter.setPen(pen)
485-
painter.drawRect(*(pt / self._dpi_ratio for pt in rect))
486+
painter.drawRect(*scaled_rect)
487+
pen.setDashOffset(3)
488+
pen.setColor(QtCore.Qt.white)
489+
painter.setPen(pen)
490+
painter.drawRect(*scaled_rect)
486491
else:
487492
def _draw_rect_callback(painter):
488493
return

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.