Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c78d16d

Browse filesBrowse files
committed
MNT: Remove minimum_descent from TextArea
This follows the deprecation period.
1 parent 59f743e commit c78d16d
Copy full SHA for c78d16d

File tree

Expand file treeCollapse file tree

2 files changed

+5
-26
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-26
lines changed

‎doc/api/next_api_changes/removals/23XXX-GL.rst

Copy file name to clipboardExpand all lines: doc/api/next_api_changes/removals/23XXX-GL.rst
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,8 @@ There is no replacement, it was considered an internal helper.
1111

1212
The **return_all** keyword argument has been removed from ``gridspec.get_position()``
1313
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
14+
15+
The **minimum_descent** has been removed from ``TextArea``
16+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
17+
18+
The minimum_descent is now effectively always True.

‎lib/matplotlib/offsetbox.py

Copy file name to clipboardExpand all lines: lib/matplotlib/offsetbox.py
-26Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -688,11 +688,9 @@ class TextArea(OffsetBox):
688688
child text.
689689
"""
690690

691-
@_api.delete_parameter("3.4", "minimumdescent")
692691
def __init__(self, s,
693692
textprops=None,
694693
multilinebaseline=False,
695-
minimumdescent=True,
696694
):
697695
"""
698696
Parameters
@@ -705,9 +703,6 @@ def __init__(self, s,
705703
multilinebaseline : bool, default: False
706704
Whether the baseline for multiline text is adjusted so that it
707705
is (approximately) center-aligned with single-line text.
708-
minimumdescent : bool, default: True
709-
If `True`, the box has a minimum descent of "p". This is now
710-
effectively always True.
711706
"""
712707
if textprops is None:
713708
textprops = {}
@@ -719,7 +714,6 @@ def __init__(self, s,
719714
self._text.set_transform(self.offset_transform +
720715
self._baseline_transform)
721716
self._multilinebaseline = multilinebaseline
722-
self._minimumdescent = minimumdescent
723717

724718
def set_text(self, s):
725719
"""Set the text of this area as a string."""
@@ -748,26 +742,6 @@ def get_multilinebaseline(self):
748742
"""
749743
return self._multilinebaseline
750744

751-
@_api.deprecated("3.4")
752-
def set_minimumdescent(self, t):
753-
"""
754-
Set minimumdescent.
755-
756-
If True, extent of the single line text is adjusted so that
757-
its descent is at least the one of the glyph "p".
758-
"""
759-
# The current implementation of Text._get_layout always behaves as if
760-
# this is True.
761-
self._minimumdescent = t
762-
self.stale = True
763-
764-
@_api.deprecated("3.4")
765-
def get_minimumdescent(self):
766-
"""
767-
Get minimumdescent.
768-
"""
769-
return self._minimumdescent
770-
771745
def set_transform(self, t):
772746
"""
773747
set_transform is ignored.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.