Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit c1a22a1

Browse filesBrowse files
dstansbydstansby
authored
Merge pull request #9915 from anntzer/depr-show-popup
Deprecate unused FigureManagerBase.show_popup.
2 parents 6336f2d + 7c4cecd commit c1a22a1
Copy full SHA for c1a22a1

File tree

Expand file treeCollapse file tree

3 files changed

+7
-3
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+7
-3
lines changed

‎doc/api/api_changes/2017-12-02-AL.rst

Copy file name to clipboard
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Deprecations
2+
````````````
3+
4+
The unused ``FigureManagerBase.show_popup`` method is deprecated. This
5+
introduced in e945059b327d42a99938b939a1be867fa023e7ba in 2005 but never built
6+
out into any of the backends.

‎doc/devel/MEP/MEP27.rst

Copy file name to clipboardExpand all lines: doc/devel/MEP/MEP27.rst
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ The description of this MEP gives us most of the solution:
114114
+--------------------------------------+------------------------------+---------------------+--------------------------------+
115115
|key_press |key_press | | |
116116
+--------------------------------------+------------------------------+---------------------+--------------------------------+
117-
|show_popup |show_poup | |Not used anywhere in mpl, and |
118-
| | | |does nothing. |
119-
+--------------------------------------+------------------------------+---------------------+--------------------------------+
120117
|get_window_title | |get_window_title | |
121118
+--------------------------------------+------------------------------+---------------------+--------------------------------+
122119
|set_window_title | |set_window_title | |

‎lib/matplotlib/backend_bases.py

Copy file name to clipboardExpand all lines: lib/matplotlib/backend_bases.py
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2697,6 +2697,7 @@ def key_press(self, event):
26972697
if rcParams['toolbar'] != 'toolmanager':
26982698
key_press_handler(event, self.canvas, self.canvas.toolbar)
26992699

2700+
@cbook.deprecated("2.2")
27002701
def show_popup(self, msg):
27012702
"""Display message in a popup -- GUI only."""
27022703

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.