Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b7837b3

Browse filesBrowse files
authored
Merge pull request #12126 from meeseeksmachine/auto-backport-of-pr-12117-on-v3.0.x
Backport PR #12117 on branch v3.0.x (Fix Agg extent calculations for empty draws)
2 parents 4844d7d + ce2cb92 commit b7837b3
Copy full SHA for b7837b3

File tree

Expand file treeCollapse file tree

2 files changed

+17
-4
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+17
-4
lines changed

‎lib/matplotlib/tests/test_backend_pdf.py

Copy file name to clipboardExpand all lines: lib/matplotlib/tests/test_backend_pdf.py
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,3 +232,11 @@ def test_failing_latex(tmpdir):
232232
plt.xlabel("$22_2_2$")
233233
with pytest.raises(RuntimeError):
234234
plt.savefig(path)
235+
236+
237+
def test_empty_rasterised():
238+
# Check that emtpy figures that are rasterised save to pdf files fine
239+
with PdfPages(io.BytesIO()) as pdf:
240+
fig, ax = plt.subplots()
241+
ax.plot([], [], rasterized=True)
242+
fig.savefig(pdf, format="pdf")

‎src/_backend_agg.cpp

Copy file name to clipboardExpand all lines: src/_backend_agg.cpp
+9-4Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,15 @@ agg::rect_i RendererAgg::get_content_extents()
201201
}
202202
}
203203

204-
r.x1 = std::max(0, r.x1);
205-
r.y1 = std::max(0, r.y1);
206-
r.x2 = std::min(r.x2 + 1, (int)width);
207-
r.y2 = std::min(r.y2 + 1, (int)height);
204+
if (r.x1 == width && r.x2 == 0) {
205+
// The buffer is completely empty.
206+
r.x1 = r.y1 = r.x2 = r.y2 = 0;
207+
} else {
208+
r.x1 = std::max(0, r.x1);
209+
r.y1 = std::max(0, r.y1);
210+
r.x2 = std::min(r.x2 + 1, (int)width);
211+
r.y2 = std::min(r.y2 + 1, (int)height);
212+
}
208213

209214
return r;
210215
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.