Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit a46f134

Browse filesBrowse files
anntzeranntzer
committed
Add support for minor ticks in 3d axes.
The actual implementation is shorter than deleting the copies of "Minor ticks are not supported" in the various docstrings...
1 parent e8b40f9 commit a46f134
Copy full SHA for a46f134

File tree

Expand file treeCollapse file tree

6 files changed

+68
-48
lines changed
Filter options
Expand file treeCollapse file tree

6 files changed

+68
-48
lines changed

‎doc/users/next_whats_new/2019-06-25-AL.rst

Copy file name to clipboard
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
3D axes now support minor ticks
2+
```````````````````````````````

‎lib/matplotlib/axis.py

Copy file name to clipboardExpand all lines: lib/matplotlib/axis.py
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ def __init__(self, axes, loc, label,
9999
self._name = name
100100

101101
self._loc = loc
102+
self._major = major
102103

103104
if size is None:
104105
if major:

‎lib/mpl_toolkits/mplot3d/axes3d.py

Copy file name to clipboardExpand all lines: lib/mpl_toolkits/mplot3d/axes3d.py
-16Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -862,9 +862,6 @@ def set_zticks(self, *args, **kwargs):
862862
Set z-axis tick locations.
863863
See :meth:`matplotlib.axes.Axes.set_yticks` for more details.
864864
865-
.. note::
866-
Minor ticks are not supported.
867-
868865
.. versionadded:: 1.1.0
869866
"""
870867
return self.zaxis.set_ticks(*args, **kwargs)
@@ -874,9 +871,6 @@ def get_zticks(self, minor=False):
874871
Return the z ticks as a list of locations
875872
See :meth:`matplotlib.axes.Axes.get_yticks` for more details.
876873
877-
.. note::
878-
Minor ticks are not supported.
879-
880874
.. versionadded:: 1.1.0
881875
"""
882876
return self.zaxis.get_ticklocs(minor=minor)
@@ -894,10 +888,6 @@ def get_zminorticklabels(self):
894888
"""
895889
Get the ztick labels as a list of Text instances
896890
897-
.. note::
898-
Minor ticks are not supported. This function was added
899-
only for completeness.
900-
901891
.. versionadded :: 1.1.0
902892
"""
903893
return cbook.silent_list('Text zticklabel',
@@ -908,9 +898,6 @@ def set_zticklabels(self, *args, **kwargs):
908898
Set z-axis tick labels.
909899
See :meth:`matplotlib.axes.Axes.set_yticklabels` for more details.
910900
911-
.. note::
912-
Minor ticks are not supported by Axes3D objects.
913-
914901
.. versionadded:: 1.1.0
915902
"""
916903
return self.zaxis.set_ticklabels(*args, **kwargs)
@@ -920,9 +907,6 @@ def get_zticklabels(self, minor=False):
920907
Get ztick labels as a list of Text instances.
921908
See :meth:`matplotlib.axes.Axes.get_yticklabels` for more details.
922909
923-
.. note::
924-
Minor ticks are not supported.
925-
926910
.. versionadded:: 1.1.0
927911
"""
928912
return cbook.silent_list('Text zticklabel',

‎lib/mpl_toolkits/mplot3d/axis3d.py

Copy file name to clipboardExpand all lines: lib/mpl_toolkits/mplot3d/axis3d.py
+54-32Lines changed: 54 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -73,33 +73,48 @@ def __init__(self, adir, v_intervalx, d_intervalx, axes, *args,
7373
# Do not depend on this existing in future releases!
7474
self._axinfo = self._AXINFO[adir].copy()
7575
if rcParams['_internal.classic_mode']:
76-
self._axinfo.update(
77-
{'label': {'va': 'center',
78-
'ha': 'center'},
79-
'tick': {'inward_factor': 0.2,
80-
'outward_factor': 0.1,
81-
'linewidth': rcParams['lines.linewidth']},
82-
'axisline': {'linewidth': 0.75,
83-
'color': (0, 0, 0, 1)},
84-
'grid': {'color': (0.9, 0.9, 0.9, 1),
85-
'linewidth': 1.0,
86-
'linestyle': '-'},
87-
})
76+
self._axinfo.update({
77+
'label': {'va': 'center', 'ha': 'center'},
78+
'tick': {
79+
'inward_factor': 0.2,
80+
'outward_factor': 0.1,
81+
'linewidth': {
82+
True: rcParams['lines.linewidth'], # major
83+
False: rcParams['lines.linewidth'], # minor
84+
}
85+
},
86+
'axisline': {'linewidth': 0.75, 'color': (0, 0, 0, 1)},
87+
'grid': {
88+
'color': (0.9, 0.9, 0.9, 1),
89+
'linewidth': 1.0,
90+
'linestyle': '-',
91+
},
92+
})
8893
else:
89-
self._axinfo.update(
90-
{'label': {'va': 'center',
91-
'ha': 'center'},
92-
'tick': {'inward_factor': 0.2,
93-
'outward_factor': 0.1,
94-
'linewidth': rcParams.get(
95-
adir + 'tick.major.width',
96-
rcParams['xtick.major.width'])},
97-
'axisline': {'linewidth': rcParams['axes.linewidth'],
98-
'color': rcParams['axes.edgecolor']},
99-
'grid': {'color': rcParams['grid.color'],
100-
'linewidth': rcParams['grid.linewidth'],
101-
'linestyle': rcParams['grid.linestyle']},
102-
})
94+
self._axinfo.update({
95+
'label': {'va': 'center', 'ha': 'center'},
96+
'tick': {
97+
'inward_factor': 0.2,
98+
'outward_factor': 0.1,
99+
'linewidth': {
100+
True: ( # major
101+
rcParams['xtick.major.width'] if adir in 'xz' else
102+
rcParams['ytick.major.width']),
103+
False: ( # minor
104+
rcParams['xtick.minor.width'] if adir in 'xz' else
105+
rcParams['ytick.minor.width']),
106+
}
107+
},
108+
'axisline': {
109+
'linewidth': rcParams['axes.linewidth'],
110+
'color': rcParams['axes.edgecolor'],
111+
},
112+
'grid': {
113+
'color': rcParams['grid.color'],
114+
'linewidth': rcParams['grid.linewidth'],
115+
'linestyle': rcParams['grid.linestyle'],
116+
},
117+
})
103118

104119
maxis.XAxis.__init__(self, axes, *args, **kwargs)
105120

@@ -140,11 +155,17 @@ def get_tick_positions(self):
140155
def get_major_ticks(self, numticks=None):
141156
ticks = maxis.XAxis.get_major_ticks(self, numticks)
142157
for t in ticks:
143-
t.tick1line.set_transform(self.axes.transData)
144-
t.tick2line.set_transform(self.axes.transData)
145-
t.gridline.set_transform(self.axes.transData)
146-
t.label1.set_transform(self.axes.transData)
147-
t.label2.set_transform(self.axes.transData)
158+
for obj in [
159+
t.tick1line, t.tick2line, t.gridline, t.label1, t.label2]:
160+
obj.set_transform(self.axes.transData)
161+
return ticks
162+
163+
def get_minor_ticks(self, numticks=None):
164+
ticks = maxis.XAxis.get_minor_ticks(self, numticks)
165+
for t in ticks:
166+
for obj in [
167+
t.tick1line, t.tick2line, t.gridline, t.label1, t.label2]:
168+
obj.set_transform(self.axes.transData)
148169
return ticks
149170

150171
def set_pane_pos(self, xys):
@@ -415,7 +436,8 @@ def draw(self, renderer):
415436
renderer.M)
416437

417438
tick_update_position(tick, (x1, x2), (y1, y2), (lx, ly))
418-
tick.tick1line.set_linewidth(info['tick']['linewidth'])
439+
tick.tick1line.set_linewidth(
440+
info['tick']['linewidth'][tick._major])
419441
tick.draw(renderer)
420442

421443
renderer.close_group('axis3d')

‎lib/mpl_toolkits/tests/baseline_images/test_mplot3d/minor_ticks.png

Copy file name to clipboard
58.2 KB
Loading

‎lib/mpl_toolkits/tests/test_mplot3d.py

Copy file name to clipboardExpand all lines: lib/mpl_toolkits/tests/test_mplot3d.py
+11Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -903,3 +903,14 @@ def test_ax3d_tickcolour():
903903
assert tick.tick1line._color == 'red'
904904
for tick in ax.zaxis.get_major_ticks():
905905
assert tick.tick1line._color == 'red'
906+
907+
908+
@image_comparison(["minor_ticks.png"], style="default")
909+
def test_minor_ticks():
910+
ax = plt.figure().add_subplot(projection="3d")
911+
ax.set_xticks([0.25], minor=True)
912+
ax.set_xticklabels(["quarter"], minor=True)
913+
ax.set_yticks([0.33], minor=True)
914+
ax.set_yticklabels(["third"], minor=True)
915+
ax.set_zticks([0.50], minor=True)
916+
ax.set_zticklabels(["half"], minor=True)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.