File tree Expand file tree Collapse file tree 1 file changed +11
-4
lines changed
Filter options
Expand file tree Collapse file tree 1 file changed +11
-4
lines changed
Original file line number Diff line number Diff line change @@ -168,10 +168,17 @@ C/C++ extensions
168168PR Review guidelines
169169====================
170170
171- * We run on a 'use your judgement' system (for better or worse) and do
172- not have a strict 'N devs must sign off on' rule. If you have a
173- commit bit, then you are trusted to use it and to know when to ask
174- for more review.
171+ * If you have a commit bit, then you are trusted to use it. Please
172+ help review and merge PRs!
173+
174+ * Two developers (those with commit rights) should review all pull
175+ requests. If you are the first to review a PR please and approve of
176+ the changes please edit the title to include ``'[MRG+1]' `` and use
177+ the github 'approve review' tool to mark it as such. If you are a
178+ subsequent reviewer and you approve either merge (and backport if
179+ needed) or increment the number in the title to ask for further
180+ review (and trigger the gh 'approve review'). If you do the merge please
181+ removed the ``'[MRG+N'] `` prefix.
175182
176183* Do not self merge, except for 'small' patches to un-break the CI.
177184
You can’t perform that action at this time.
0 commit comments