Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9be011d

Browse filesBrowse files
authored
Merge pull request #15349 from timhoffm/pr-checklist
Use checkboxes as bullet points for the PR review checklists
2 parents 1fad1d2 + 51ff302 commit 9be011d
Copy full SHA for 9be011d

File tree

Expand file treeCollapse file tree

1 file changed

+15
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+15
-0
lines changed

‎doc/devel/coding_guide.rst

Copy file name to clipboardExpand all lines: doc/devel/coding_guide.rst
+15Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
.. _pr-guidelines:
22

3+
.. raw:: html
4+
5+
<style>
6+
.checklist { list-style: none; padding: 0; margin: 0; }
7+
.checklist li { margin-left: 24px; padding-left: 23px; margin-right: 6px; }
8+
.checklist li:before { content: "\2610\2001"; margin-left: -24px; }
9+
.checklist li p {display: inline; }
10+
</style>
11+
312
***********************
413
Pull request guidelines
514
***********************
@@ -23,6 +32,8 @@ Summary for PR authors
2332

2433
When making a PR, pay attention to:
2534

35+
.. rst-class:: checklist
36+
2637
* :ref:`Target the master branch <pr-branch-selection>`.
2738
* Adhere to the :ref:`coding_guidelines`.
2839
* Update the :ref:`documentation <pr-documentation>` if necessary.
@@ -53,13 +64,17 @@ Summary for PR reviewers
5364

5465
Content topics:
5566

67+
.. rst-class:: checklist
68+
5669
* Is the feature / bugfix reasonable?
5770
* Does the PR conform with the :ref:`coding_guidelines`?
5871
* Is the :ref:`documentation <pr-documentation>` (docstrings, examples,
5972
what's new, API changes) updated?
6073

6174
Organizational topics:
6275

76+
.. rst-class:: checklist
77+
6378
* Make sure all :ref:`automated tests <pr-automated-tests>` pass.
6479
* The PR should :ref:`target the master branch <pr-branch-selection>`.
6580
* Tag with descriptive :ref:`labels <pr-labels>`.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.