Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 88da735

Browse filesBrowse files
committed
Mention labels and milestones in PR review guidelines
1 parent cbd0409 commit 88da735
Copy full SHA for 88da735

File tree

Expand file treeCollapse file tree

1 file changed

+26
-7
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+26
-7
lines changed

‎doc/devel/coding_guide.rst

Copy file name to clipboardExpand all lines: doc/devel/coding_guide.rst
+26-7Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,9 @@ Pull request checklist
1212
Branch selection
1313
----------------
1414

15-
In general target the master branch for all new features and
16-
bug-fixes. PRs may target maintenance or doc branches on
17-
a case-by-case basis.
18-
15+
Generally, all pull requests (*PRs*) should target the master branch. Other
16+
branches are fed through automatic or manual backports. Directly targeting
17+
other branches is only rarely necessary for special maintenance work.
1918

2019
Documentation
2120
-------------
@@ -24,9 +23,10 @@ Documentation
2423
forget to add a new rst file to the API docs.
2524

2625
* Each high-level plotting function should have a small example in
27-
the `Example` section of the docstring. This should be as simple as
28-
possible to demonstrate the method. More complex examples should go
29-
in the `examples` section of the documentation.
26+
the ``Examples`` section of the docstring. This should be as simple as
27+
possible to demonstrate the method. More complex examples should go into
28+
a dedicated example file in the :file:`examples` directory, which will be
29+
rendered to the examples gallery in the documentation.
3030

3131
* Build the docs and make sure all formatting warnings are addressed.
3232

@@ -47,6 +47,23 @@ PR Review guidelines
4747
* If you have commit rights, then you are trusted to use them. Please
4848
help review and merge PRs!
4949

50+
* If you have the rights to set labels, tag the PR with descriptive labels.
51+
See the `list of labels <https://github.com/matplotlib/matplotlib/labels>`__.
52+
53+
* Set the milestone according to these rules:
54+
55+
* *New features* are milestoned for the next point-release ``v3.X.0``
56+
57+
* *Bugfixes and docstring changes* are milestoned for the next bugfix
58+
release ``v3.X.Y``
59+
60+
* *Documentation changes* (all *.rst files and examples) are milestoned
61+
``v3.X-doc``
62+
63+
All of these PRs should target the master branch. The milestone tag triggers
64+
an :ref:`automatic backport <automated-backports>` for milestones which have
65+
a corresponding branch.
66+
5067
* Documentation and examples may be merged by the first reviewer. Use
5168
the threshold "is this better than it was?" as the review criteria.
5269

@@ -138,6 +155,8 @@ The only changes to be backported to 2.2.N-doc are changes to
138155
``doc``, ``examples``, or ``tutorials``. Any changes to
139156
``lib`` or ``src`` should not be backported to this branch.
140157

158+
.. _automated-backports:
159+
141160
Automated backports
142161
-------------------
143162

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.