@@ -12,10 +12,9 @@ Pull request checklist
12
12
Branch selection
13
13
----------------
14
14
15
- In general target the master branch for all new features and
16
- bug-fixes. PRs may target maintenance or doc branches on
17
- a case-by-case basis.
18
-
15
+ Generally, all pull requests (*PRs *) should target the master branch. Other
16
+ branches are fed through automatic or manual backports. Directly targeting
17
+ other branches is only rarely necessary for special maintenance work.
19
18
20
19
Documentation
21
20
-------------
@@ -24,9 +23,10 @@ Documentation
24
23
forget to add a new rst file to the API docs.
25
24
26
25
* Each high-level plotting function should have a small example in
27
- the `Example ` section of the docstring. This should be as simple as
28
- possible to demonstrate the method. More complex examples should go
29
- in the `examples ` section of the documentation.
26
+ the ``Examples `` section of the docstring. This should be as simple as
27
+ possible to demonstrate the method. More complex examples should go into
28
+ a dedicated example file in the :file: `examples ` directory, which will be
29
+ rendered to the examples gallery in the documentation.
30
30
31
31
* Build the docs and make sure all formatting warnings are addressed.
32
32
@@ -47,6 +47,23 @@ PR Review guidelines
47
47
* If you have commit rights, then you are trusted to use them. Please
48
48
help review and merge PRs!
49
49
50
+ * If you have the rights to set labels, tag the PR with descriptive labels.
51
+ See the `list of labels <https://github.com/matplotlib/matplotlib/labels >`__.
52
+
53
+ * Set the milestone according to these rules:
54
+
55
+ * *New features * are milestoned for the next point-release ``v3.X.0 ``
56
+
57
+ * *Bugfixes and docstring changes * are milestoned for the next bugfix
58
+ release ``v3.X.Y ``
59
+
60
+ * *Documentation changes * (all *.rst files and examples) are milestoned
61
+ ``v3.X-doc``
62
+
63
+ All of these PRs should target the master branch. The milestone tag triggers
64
+ an :ref: `automatic backport <automated-backports >` for milestones which have
65
+ a corresponding branch.
66
+
50
67
* Documentation and examples may be merged by the first reviewer. Use
51
68
the threshold "is this better than it was?" as the review criteria.
52
69
@@ -138,6 +155,8 @@ The only changes to be backported to 2.2.N-doc are changes to
138
155
``doc ``, ``examples ``, or ``tutorials ``. Any changes to
139
156
``lib `` or ``src `` should not be backported to this branch.
140
157
158
+ .. _automated-backports :
159
+
141
160
Automated backports
142
161
-------------------
143
162
0 commit comments