Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 84c5d78

Browse filesBrowse files
committed
Mention labels and milestones in PR review guidelines
1 parent cbd0409 commit 84c5d78
Copy full SHA for 84c5d78

File tree

Expand file treeCollapse file tree

1 file changed

+18
-3
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+18
-3
lines changed

‎doc/devel/coding_guide.rst

Copy file name to clipboardExpand all lines: doc/devel/coding_guide.rst
+18-3Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ Pull request checklist
1212
Branch selection
1313
----------------
1414

15-
In general target the master branch for all new features and
16-
bug-fixes. PRs may target maintenance or doc branches on
17-
a case-by-case basis.
15+
In general target the master branch for all new features and bug-fixes.
16+
Pull requests (*PRs*) may target maintenance or doc branches on a case-by-case
17+
basis.
1818

1919

2020
Documentation
@@ -47,6 +47,19 @@ PR Review guidelines
4747
* If you have commit rights, then you are trusted to use them. Please
4848
help review and merge PRs!
4949

50+
* If you have the rights to set labels, tag the PR with descriptive labels.
51+
See the `list of labels <https://github.com/matplotlib/matplotlib/labels>`__.
52+
53+
* Set the milestone to
54+
55+
* the next point-release for new features; e.g. ``v3.X.0``
56+
57+
* the next bugfix release for bugfixes; e.g. ``v.3.X.Y``
58+
59+
All PRs for features and bug fixes should target the master branch. The
60+
milestone tag triggers an :ref:`automatical backport <automated-backports>`.
61+
for milestones which have a corresponding branch.
62+
5063
* Documentation and examples may be merged by the first reviewer. Use
5164
the threshold "is this better than it was?" as the review criteria.
5265

@@ -138,6 +151,8 @@ The only changes to be backported to 2.2.N-doc are changes to
138151
``doc``, ``examples``, or ``tutorials``. Any changes to
139152
``lib`` or ``src`` should not be backported to this branch.
140153

154+
.. _automated-backports:
155+
141156
Automated backports
142157
-------------------
143158

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.