Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 60b641d

Browse filesBrowse files
committed
Check the return code when saving a movie with files.
When using temporary files, we only run the movie creation process once, rather than keeping an open pipe. As a result, we only get an error here. Without this change, if the process fails, there is no error message.
1 parent ed6a250 commit 60b641d
Copy full SHA for 60b641d

File tree

Expand file treeCollapse file tree

1 file changed

+7
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-0
lines changed

‎lib/matplotlib/animation.py

Copy file name to clipboardExpand all lines: lib/matplotlib/animation.py
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,13 @@ def finish(self):
322322
self._run()
323323
MovieWriter.finish(self) # Will call clean-up
324324

325+
# Check error code for creating file here, since we just run
326+
# the process here, rather than having an open pipe.
327+
if self._proc.returncode:
328+
raise RuntimeError('Error creating movie, return code: '
329+
+ str(self._proc.returncode)
330+
+ ' Try running with --verbose-debug')
331+
325332
def cleanup(self):
326333
MovieWriter.cleanup(self)
327334

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.