Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5869ed0

Browse filesBrowse files
committed
Add a version number in the qlmanage cache key
1 parent 7a9e97d commit 5869ed0
Copy full SHA for 5869ed0

File tree

2 files changed

+5
-3
lines changed
Filter options

2 files changed

+5
-3
lines changed

‎lib/matplotlib/__init__.py

Copy file name to clipboardExpand all lines: lib/matplotlib/__init__.py
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -385,10 +385,12 @@ def impl(args, regex, min_ver=None, ignore_exit_code=False):
385385
stdout=subprocess.DEVNULL,
386386
stderr=subprocess.DEVNULL
387387
)
388+
# qlmanage has no version number, use the OS version
389+
version = subprocess.check_output(["sw_vers", "-productVersion"])
388390
except (FileNotFoundError, subprocess.CalledProcessError):
389391
raise ExecutableNotFoundError()
390-
return _ExecInfo("qlmanage", "")
391-
392+
else:
393+
return _ExecInfo("qlmanage", version)
392394
else:
393395
raise ValueError("Unknown executable: {!r}".format(name))
394396

‎lib/matplotlib/testing/compare.py

Copy file name to clipboardExpand all lines: lib/matplotlib/testing/compare.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def __init__(self):
126126
self._proc = None
127127
self._tmpdir = TemporaryDirectory()
128128
self._tmppath = Path(self._tmpdir.name)
129-
self._version = 'qlmanage'
129+
self._version = mpl._get_executable_info("qlmanage").version
130130

131131
def __call__(self, orig, dest):
132132
try:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.