Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4b0196e

Browse filesBrowse files
ImportanceOfBeingErnesttimhoffm
authored andcommitted
tickminorvisible-fix (#12938)
1 parent e99be22 commit 4b0196e
Copy full SHA for 4b0196e

File tree

Expand file treeCollapse file tree

2 files changed

+20
-1
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+20
-1
lines changed

‎lib/matplotlib/scale.py

Copy file name to clipboardExpand all lines: lib/matplotlib/scale.py
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ def set_default_locators_and_formatters(self, axis):
6969
axis.set_major_formatter(ScalarFormatter())
7070
axis.set_minor_formatter(NullFormatter())
7171
# update the minor locator for x and y axis based on rcParams
72-
if rcParams['xtick.minor.visible']:
72+
if (axis.axis_name == 'x' and rcParams['xtick.minor.visible']
73+
or axis.axis_name == 'y' and rcParams['ytick.minor.visible']):
7374
axis.set_minor_locator(AutoMinorLocator())
7475
else:
7576
axis.set_minor_locator(NullLocator())

‎lib/matplotlib/tests/test_ticker.py

Copy file name to clipboardExpand all lines: lib/matplotlib/tests/test_ticker.py
+18Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -851,3 +851,21 @@ def test_minlocator_type():
851851
fig, ax = plt.subplots()
852852
with pytest.raises(TypeError):
853853
ax.xaxis.set_minor_locator(matplotlib.ticker.LogFormatter())
854+
855+
856+
def test_minorticks_rc():
857+
fig = plt.figure()
858+
859+
def minorticksubplot(xminor, yminor, i):
860+
rc = {'xtick.minor.visible': xminor,
861+
'ytick.minor.visible': yminor}
862+
with plt.rc_context(rc=rc):
863+
ax = fig.add_subplot(2, 2, i)
864+
865+
assert (len(ax.xaxis.get_minor_ticks()) > 0) == xminor
866+
assert (len(ax.yaxis.get_minor_ticks()) > 0) == yminor
867+
868+
minorticksubplot(False, False, 1)
869+
minorticksubplot(True, False, 2)
870+
minorticksubplot(False, True, 3)
871+
minorticksubplot(True, True, 4)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.