Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4754b58

Browse filesBrowse files
authored
Merge pull request #11972 from jklymak/fix-mem-leak-repeated=draw
FIX: close mem leak for repeated draw
2 parents 21ec4fc + 3325bde commit 4754b58
Copy full SHA for 4754b58

File tree

Expand file treeCollapse file tree

1 file changed

+11
-2
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+11
-2
lines changed

‎lib/matplotlib/transforms.py

Copy file name to clipboardExpand all lines: lib/matplotlib/transforms.py
+11-2Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,11 @@ def __getstate__(self):
110110
def __setstate__(self, data_dict):
111111
self.__dict__ = data_dict
112112
# turn the normal dictionary back into a dictionary with weak values
113-
self._parents = {k: weakref.ref(v)
113+
# The extra lambda is to provide a callback to remove dead
114+
# weakrefs from the dictionary when garbage collection is done.
115+
self._parents = {k: weakref.ref(v, lambda ref, sid=k,
116+
target=self._parents:
117+
target.pop(sid))
114118
for k, v in self._parents.items() if v is not None}
115119

116120
def __copy__(self, *args):
@@ -168,7 +172,12 @@ def set_children(self, *children):
168172
# parents are destroyed, references from the children won't
169173
# keep them alive.
170174
for child in children:
171-
child._parents[id(self)] = weakref.ref(self)
175+
# Use weak references so this dictionary won't keep obsolete nodes
176+
# alive; the callback deletes the dictionary entry. This is a
177+
# performance improvement over using WeakValueDictionary.
178+
ref = weakref.ref(self, lambda ref, sid=id(self),
179+
target=child._parents: target.pop(sid))
180+
child._parents[id(self)] = ref
172181

173182
if DEBUG:
174183
_set_children = set_children

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.