Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 3378fa9

Browse filesBrowse files
timhoffmtimhoffm
committed
DOC: Add policy for people stating concurrent interest
While we formally do not resevere issues, it happens regularly, in particular on good first issues, that multiple people communicate interest to work on the issue (most recently in #29647). I feel the need to give a procedure how to handle this. We don't want person A to state interest, start coding and meanwhile person B snatches the topic and provides a PR. And I don't want to manually sort who should be doing what anymore. With this addition we can simply point to our guidelines, and people can have clear expectations. I therefore propose a courtsy time of 24h for not opening a PR if somebody has stated interest to do so. - The 24h is somewhat arbitrary, but long enough so that somebody who is actively working on the issue should produce a result, and short enough to not block other people.
1 parent c9402f3 commit 3378fa9
Copy full SHA for 3378fa9

File tree

1 file changed

+12
-3
lines changed
Filter options

1 file changed

+12
-3
lines changed

‎doc/devel/contribute.rst

Copy file name to clipboardExpand all lines: doc/devel/contribute.rst
+12-3Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -319,15 +319,24 @@ Choose an issue
319319
===============
320320

321321
In general, the Matplotlib project does not assign issues. Issues are
322-
"assigned" or "claimed" by opening a PR; there is no other assignment
323-
mechanism. If you have opened such a PR, please comment on the issue thread to
324-
avoid duplication of work. Please check if there is an existing PR for the
322+
"assigned" or "claimed" by opening a PR; there is no other assignment mechanism.
323+
When opening a PR, please ensure it's visible in the issue to prevent duplicate
324+
work, preferably by mentioning the issue in the PR message ("Closes #12345") or
325+
explicit linking in the UI, or commenting on the issue.
326+
327+
Please check if there is an existing PR for the
325328
issue you are addressing. If there is, try to work with the author by
326329
submitting reviews of their code or commenting on the PR rather than opening
327330
a new PR; duplicate PRs are subject to being closed. However, if the existing
328331
PR is an outline, unlikely to work, or stalled, and the original author is
329332
unresponsive, feel free to open a new PR referencing the old one.
330333

334+
Some people state the intention to work on a topic. While this is not a formal
335+
reservation, it's courteous to not start concurrent work. Offer to collaborate
336+
if the topic is more complex. For simple topics, in particular *good first issues*,
337+
you can start working yourself if there has been no reaction (opened PR or new
338+
comment) for 24h by the previous person.
339+
331340
.. _how-to-pull-request:
332341

333342
Start a pull request

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.