Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 14a04a0

Browse filesBrowse files
authored
Merge pull request #28275 from tacaswell/revive_filenames
Revive sanitizing default filenames extracted from UI window titles
2 parents 7275ad9 + 4356bfe commit 14a04a0
Copy full SHA for 14a04a0

File tree

Expand file treeCollapse file tree

1 file changed

+16
-9
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+16
-9
lines changed
Open diff view settings
Collapse file

‎lib/matplotlib/backend_bases.py‎

Copy file name to clipboardExpand all lines: lib/matplotlib/backend_bases.py
+16-9Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2241,15 +2241,22 @@ def get_default_filetype(cls):
22412241

22422242
def get_default_filename(self):
22432243
"""
2244-
Return a string, which includes extension, suitable for use as
2245-
a default filename.
2246-
"""
2247-
basename = (self.manager.get_window_title() if self.manager is not None
2248-
else '')
2249-
basename = (basename or 'image').replace(' ', '_')
2250-
filetype = self.get_default_filetype()
2251-
filename = basename + '.' + filetype
2252-
return filename
2244+
Return a suitable default filename, including the extension.
2245+
"""
2246+
default_basename = (
2247+
self.manager.get_window_title()
2248+
if self.manager is not None
2249+
else ''
2250+
)
2251+
default_basename = default_basename or 'image'
2252+
# Characters to be avoided in a NT path:
2253+
# https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#naming_conventions
2254+
# plus ' '
2255+
removed_chars = r'<>:"/\|?*\0 '
2256+
default_basename = default_basename.translate(
2257+
{ord(c): "_" for c in removed_chars})
2258+
default_filetype = self.get_default_filetype()
2259+
return f'{default_basename}.{default_filetype}'
22532260

22542261
@_api.deprecated("3.8")
22552262
def switch_backends(self, FigureCanvasClass):

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.