Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 010aa96

Browse filesBrowse files
authored
Merge pull request #14522 from meeseeksmachine/auto-backport-of-pr-14040-on-v3.1.x
Backport PR #14040 on branch v3.1.x (Gracefully handle non-finite z in tricontour (issue #10167))
2 parents dfc8dbd + e8ddc95 commit 010aa96
Copy full SHA for 010aa96

File tree

Expand file treeCollapse file tree

2 files changed

+39
-3
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+39
-3
lines changed

‎lib/matplotlib/tests/test_triangulation.py

Copy file name to clipboardExpand all lines: lib/matplotlib/tests/test_triangulation.py
+24Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1122,3 +1122,27 @@ def test_qhull_large_offset():
11221122
triang = mtri.Triangulation(x, y)
11231123
triang_offset = mtri.Triangulation(x + offset, y + offset)
11241124
assert len(triang.triangles) == len(triang_offset.triangles)
1125+
1126+
1127+
def test_tricontour_non_finite_z():
1128+
# github issue 10167.
1129+
x = [0, 1, 0, 1]
1130+
y = [0, 0, 1, 1]
1131+
triang = mtri.Triangulation(x, y)
1132+
plt.figure()
1133+
1134+
with pytest.raises(ValueError, match='z array must not contain non-finite '
1135+
'values within the triangulation'):
1136+
plt.tricontourf(triang, [0, 1, 2, np.inf])
1137+
1138+
with pytest.raises(ValueError, match='z array must not contain non-finite '
1139+
'values within the triangulation'):
1140+
plt.tricontourf(triang, [0, 1, 2, -np.inf])
1141+
1142+
with pytest.raises(ValueError, match='z array must not contain non-finite '
1143+
'values within the triangulation'):
1144+
plt.tricontourf(triang, [0, 1, 2, np.nan])
1145+
1146+
with pytest.raises(ValueError, match='z must not contain masked points '
1147+
'within the triangulation'):
1148+
plt.tricontourf(triang, np.ma.array([0, 1, 2, 3], mask=[1, 0, 0, 0]))

‎lib/matplotlib/tri/tricontour.py

Copy file name to clipboardExpand all lines: lib/matplotlib/tri/tricontour.py
+15-3Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,24 @@ def _contour_args(self, args, kwargs):
7979
fn = 'contour'
8080
tri, args, kwargs = Triangulation.get_from_args_and_kwargs(*args,
8181
**kwargs)
82-
z = np.asarray(args[0])
82+
z = np.ma.asarray(args[0])
8383
if z.shape != tri.x.shape:
8484
raise ValueError('z array must have same length as triangulation x'
8585
' and y arrays')
86-
self.zmax = z.max()
87-
self.zmin = z.min()
86+
87+
# z values must be finite, only need to check points that are included
88+
# in the triangulation.
89+
z_check = z[np.unique(tri.get_masked_triangles())]
90+
if np.ma.is_masked(z_check):
91+
raise ValueError('z must not contain masked points within the '
92+
'triangulation')
93+
if not np.isfinite(z_check).all():
94+
raise ValueError('z array must not contain non-finite values '
95+
'within the triangulation')
96+
97+
z = np.ma.masked_invalid(z, copy=False)
98+
self.zmax = float(z_check.max())
99+
self.zmin = float(z_check.min())
88100
if self.logscale and self.zmin <= 0:
89101
raise ValueError('Cannot %s log of negative values.' % fn)
90102
self._contour_level_args(z, args[1:])

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.