Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

DOC: add CoC committee #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2022
Merged

DOC: add CoC committee #26

merged 1 commit into from
Jul 1, 2022

Conversation

tacaswell
Copy link
Member

As discussed on the 2022-06-30 call.

We plan to re-vamp this sub-committee in the next 9-12 months, but start with this list.

@tacaswell
Copy link
Member Author

@jklymak Is this the same failure we had on the brochure site?

@tacaswell tacaswell mentioned this pull request Jul 1, 2022
Merged
@jklymak
Copy link
Member

jklymak commented Jul 1, 2022 •
edited
Loading

Yes @QuLogic tracked it to having to pin pygments.

@jklymak
Copy link
Member

jklymak commented Jul 1, 2022

Probably, until we release 3.6 and the website changes on dev, we should pin pydata-sphinx-theme to be <0.9.0

@jklymak jklymak mentioned this pull request Jul 1, 2022
Merged
@efiring
Copy link
Member

efiring commented Jul 1, 2022

I tried rerunning the checks with the pinned pydata_sphinx_theme, but it fails with

Extension error (pydata_sphinx_theme):
Handler <function _overwrite_pygments_css at 0x7f8f5b3b6ca0> for event 'build-finished' threw an exception (exception: 'HtmlFormatter' object has no attribute 'get_linenos_style_defs')
make: *** [Makefile:32: html] Error 2
Error: Process completed with exit code 2.

@jklymak
Copy link
Member

jklymak commented Jul 1, 2022

I think you need to rebase this PR? Downloading pydata_sphinx_theme-0.9.0-py3-none-any.whl (3.3 MB)

@tacaswell tacaswell force-pushed the people_coc_committee branch from 938a5c7 to 4d2ecac Compare July 1, 2022 19:41
@tacaswell
Copy link
Member Author

rebased.

@efiring efiring merged commit 7cfbbbc into matplotlib:main Jul 1, 2022
@tacaswell tacaswell deleted the people_coc_committee branch July 1, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tacaswell @jklymak @efiring @dopplershift
Morty Proxy This is a proxified and sanitized view of the page, visit original site.