Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix StocksEquitiesDailyOpenCloseApiResponse type mappings #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
suremarc merged 1 commit into from
May 9, 2021
Merged

Fix StocksEquitiesDailyOpenCloseApiResponse type mappings #70

suremarc merged 1 commit into from
May 9, 2021

Conversation

@suremarc
Copy link
Contributor

@suremarc suremarc commented May 9, 2021

A previous update to the Swagger code created a bug due to the wrong names being put into the type mappings in StocksEquitiesDailyOpenCloseApiResponse under the REST models. See #69.

After running the updated version of the client, I am able to run the user's code successfully:

    with RESTClient(os.environ['API_KEY']) as client:
        resp = client.stocks_equities_daily_open_close("AAPL", "2018-03-02")
        print(f"On: {resp.from_} Apple opened at {resp.open} and closed at {resp.close}")

Result:

On: 2018-03-02 Apple opened at 43.2 and closed at 44.0525

@suremarc suremarc requested review from jbonzo and jcho-polygon May 9, 2021 14:44
@suremarc suremarc merged commit 1509ddd into master May 9, 2021
@suremarc suremarc deleted the fix-open-close branch May 9, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbonzo jbonzo jbonzo approved these changes

@jcho-polygon jcho-polygon Awaiting requested review from jcho-polygon

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suremarc @jbonzo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.