From 505dd5ecbfcde84d4a25f7bcd9ff2c3b531acb71 Mon Sep 17 00:00:00 2001 From: William Miller Date: Mon, 19 Jul 2021 22:33:28 -0700 Subject: [PATCH 1/4] Fixed typos in definitions.py (changed instances of todays_chang_eperc to todays_change_perc) --- polygon/rest/models/definitions.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/polygon/rest/models/definitions.py b/polygon/rest/models/definitions.py index c05b7cde..8ea70f80 100644 --- a/polygon/rest/models/definitions.py +++ b/polygon/rest/models/definitions.py @@ -1385,7 +1385,7 @@ class CryptoSnapshotTicker(Definition): "min": "min", "prevDay": "prev_day", "todaysChange": "todays_change", - "todaysChangePerc": "todays_chang_eperc", + "todaysChangePerc": "todays_change_perc", "updated": "updated", } @@ -1397,7 +1397,7 @@ class CryptoSnapshotTicker(Definition): "min": False, "prev_day": False, "todays_change": True, - "todays_chang_eperc": True, + "todays_change_perc": True, "updated": True, } @@ -1409,7 +1409,7 @@ class CryptoSnapshotTicker(Definition): "min": "CryptoSnapshotAgg", "prev_day": "CryptoSnapshotAgg", "todays_change": "int", - "todays_chang_eperc": "int", + "todays_change_perc": "int", "updated": "int", } @@ -1421,7 +1421,7 @@ def __init__(self): self.min: CryptoSnapshotAgg self.prev_day: CryptoSnapshotAgg self.todays_change: int - self.todays_chang_eperc: int + self.todays_change_perc: int self.updated: int @@ -1673,7 +1673,7 @@ class ForexSnapshotTicker(Definition): "min": "min", "prevDay": "prev_day", "todaysChange": "todays_change", - "todaysChangePerc": "todays_chang_eperc", + "todaysChangePerc": "todays_change_perc", "updated": "updated", } @@ -1685,7 +1685,7 @@ class ForexSnapshotTicker(Definition): "min": False, "prev_day": False, "todays_change": True, - "todays_chang_eperc": True, + "todays_change_perc": True, "updated": True, } @@ -1697,7 +1697,7 @@ class ForexSnapshotTicker(Definition): "min": "ForexSnapshotAgg", "prev_day": "ForexSnapshotAgg", "todays_change": "int", - "todays_chang_eperc": "int", + "todays_change_perc": "int", "updated": "int", } @@ -1709,7 +1709,7 @@ def __init__(self): self.min: ForexSnapshotAgg self.prev_day: ForexSnapshotAgg self.todays_change: int - self.todays_chang_eperc: int + self.todays_change_perc: int self.updated: int @@ -2376,7 +2376,7 @@ class StocksSnapshotTicker(Definition): "min": "min", "prevDay": "prev_day", "todaysChange": "todays_change", - "todaysChangePerc": "todays_chang_eperc", + "todaysChangePerc": "todays_change_perc", "updated": "updated", } @@ -2389,7 +2389,7 @@ class StocksSnapshotTicker(Definition): "min": False, "prev_day": False, "todays_change": True, - "todays_chang_eperc": True, + "todays_change_perc": True, "updated": True, } @@ -2402,7 +2402,7 @@ class StocksSnapshotTicker(Definition): "min": "StocksSnapshotAgg", "prev_day": "StocksSnapshotAgg", "todays_change": "int", - "todays_chang_eperc": "int", + "todays_change_perc": "int", "updated": "int", } @@ -2415,7 +2415,7 @@ def __init__(self): self.min: StocksSnapshotAgg self.prev_day: StocksSnapshotAgg self.todays_change: int - self.todays_chang_eperc: int + self.todays_change_perc: int self.updated: int From 4a5f1d49a24533efd31f0730dfa921dff86ba871 Mon Sep 17 00:00:00 2001 From: William Miller <33332811+WMiller256@users.noreply.github.com> Date: Sun, 26 Dec 2021 12:17:12 -0700 Subject: [PATCH 2/4] Add exception handle to signal creation --- polygon/websocket/websocket_client.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/polygon/websocket/websocket_client.py b/polygon/websocket/websocket_client.py index 3c046485..ae183a44 100644 --- a/polygon/websocket/websocket_client.py +++ b/polygon/websocket/websocket_client.py @@ -39,8 +39,11 @@ def __init__(self, cluster: str, auth_key: str, process_message: Optional[Callab # TODO: this probably isn't great design. # If the user defines their own signal handler then this will gets overwritten. # We still need to make sure that killing, terminating, interrupting the program closes the connection - signal.signal(signal.SIGINT, self._cleanup_signal_handler()) - signal.signal(signal.SIGTERM, self._cleanup_signal_handler()) + try: + signal.signal(signal.SIGINT, self._cleanup_signal_handler()) + signal.signal(signal.SIGTERM, self._cleanup_signal_handler()) + except ValueError: + pass def run(self): self.ws.run_forever() From b8a26982d2c99cab7886023fd6ac2331c9ff5e6a Mon Sep 17 00:00:00 2001 From: William Miller Date: Sun, 26 Dec 2021 12:53:55 -0700 Subject: [PATCH 3/4] Hard code version --- setup.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/setup.py b/setup.py index 45095315..bfdb7351 100644 --- a/setup.py +++ b/setup.py @@ -5,10 +5,7 @@ import os import sys -version = os.getenv("VERSION") -if not version: - print("no version supplied") - sys.exit(1) +version = "0.2.11" def get_readme_md_contents(): """read the contents of your README file""" From 5148a6bc9f2f3e0a6971a861d6ed237ef3367644 Mon Sep 17 00:00:00 2001 From: William Miller Date: Wed, 25 May 2022 11:30:07 -0700 Subject: [PATCH 4/4] Add logging to exception handling --- polygon/websocket/websocket_client.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/polygon/websocket/websocket_client.py b/polygon/websocket/websocket_client.py index ae183a44..df73f749 100644 --- a/polygon/websocket/websocket_client.py +++ b/polygon/websocket/websocket_client.py @@ -42,7 +42,8 @@ def __init__(self, cluster: str, auth_key: str, process_message: Optional[Callab try: signal.signal(signal.SIGINT, self._cleanup_signal_handler()) signal.signal(signal.SIGTERM, self._cleanup_signal_handler()) - except ValueError: + except ValueError as error: + print(error.message) pass def run(self):