Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d526b13

Browse filesBrowse files
bitwisemangsmet
andauthored
Apply suggestions from code review
Co-authored-by: Guillaume Smet <guillaume.smet@gmail.com>
1 parent fffe312 commit d526b13
Copy full SHA for d526b13

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed

‎src/test/java/org/kohsuke/github/ArchTests.java

Copy file name to clipboardExpand all lines: src/test/java/org/kohsuke/github/ArchTests.java
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ public void testRequireUseOfAssertThat() {
153153
@Test
154154
public void testRequireUseOfOnlySpecificApacheCommons() {
155155

156-
final ArchRule onlyApprovedApacheCommonsLang3Methods = classes()
156+
final ArchRule onlyApprovedApacheCommonsMethods = classes()
157157
.should(notCallMethodsInPackageUnless("org.apache.commons..",
158158
// unless it is one of these methods
159159
targetMethodIs(StringUtils.class, "capitalize", String.class),
@@ -187,9 +187,9 @@ public void testRequireUseOfOnlySpecificApacheCommons() {
187187
targetMethodIs(IOUtils.class, "toString", Reader.class),
188188
targetMethodIs(IOUtils.class, "toByteArray", InputStream.class)))
189189
.because(
190-
"Commons methods must be manually verified to be compatible with commons-io:2.4 or earlier and commons-lang3:3.9 or earlier should be used.");
190+
"Commons methods must be manually verified to be compatible with commons-io:2.4 or earlier and commons-lang3:3.9 or earlier.");
191191

192-
onlyApprovedApacheCommonsLang3Methods.check(classFiles);
192+
onlyApprovedApacheCommonsMethods.check(classFiles);
193193
}
194194

195195
public static ArchCondition<JavaClass> notCallMethodsInPackageUnless(final String packageIdentifier,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.