Delete optimize setting from setup.cfg, as it causes .pyc files to be included in the wheel#89
Merged
amcgregor merged 1 commit intomarrow:developmarrow/mailer:developfrom Apr 22, 2020
jwodder:remove-pycsCopy head branch name to clipboard
Merged
Delete optimize setting from setup.cfg, as it causes .pyc files to be included in the wheel#89amcgregor merged 1 commit intomarrow:developmarrow/mailer:developfrom jwodder:remove-pycsCopy head branch name to clipboard
optimize setting from setup.cfg, as it causes .pyc files to be included in the wheel#89amcgregor merged 1 commit intomarrow:developmarrow/mailer:developfrom
jwodder:remove-pycsCopy head branch name to clipboard
Conversation
included in the wheel
Codecov Report
@@ Coverage Diff @@
## develop #89 +/- ##
========================================
Coverage 53.43% 53.43%
========================================
Files 25 25
Lines 1252 1252
========================================
Hits 669 669
Misses 583 583Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project's
setup.cfgcurrently contains the lines:This has the side effect of causing optimized
*.pycfiles to be compiled & included in the wheel generated by thebdist_wheelcommand. Such files have no business being in a wheel, as (a) the files are machine-specific and thus won't be of use to most users, and (b) pip compiles its own set of*.pycfiles when installing from a wheel anyway. The setting is also of marginal utility to begin with, as it its intended purpose only takes effect when installing withsetup.py install, which is deprecated in favor of installing with pip. This PR thus removes the above lines fromsetup.cfg.