Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Console warning about aria-hidden attribute when expanding a DataGrid row#10948

Copy link
Copy link
@yelworc

Description

@yelworc
Issue body actions

What you were expecting:
No warnings in the browser console 馃槃

What happened instead:
When tapping the expand icon on an expandable DataGrid row for the first time in a session, I'm seeing this warning in the browser console:

Blocked aria-hidden on an element because its descendant retained focus. The focus must not be hidden from assistive technology users. Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which will also prevent focus. For more details, see the aria-hidden section of the WAI-ARIA specification at https://w3c.github.io/aria/#aria-hidden.
Element with focus: <div.MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall RaDatagrid-expandIcon css-1pe4mpk-MuiButtonBase-root-MuiIconButton-root>
Ancestor with aria-hidden: <div.MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall RaDatagrid-expandIcon css-1pe4mpk-MuiButtonBase-root-MuiIconButton-root>

As far as I can tell, this boils down to the aria-hidden="true" prop on the IconButton in ExpandRowButton.

I'm wondering what the reasoning behind that prop is/was (it's been there for 6 years); there are ARIA labels for the closed/expanded states, so preventing focus (and excluding it from keyboard navigation with tabIndex={-1}) seems contradictory to me. Could those two props (aria-hidden and tabIndex) just be removed?

Environment

  • React-admin version: 5.10.2
  • Last version that did not exhibit the issue (if applicable): -
  • React version: 18.3.1
  • Browser: Vivaldi 7.5.3735.66

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.