put live-reload middleware above main app #85
Conversation
Pull Request Test Coverage Report for Build 280
💛 - Coveralls |
|
What happens if you use this in conjunction with the live reload browser plugin? |
|
Oh, good question. I don't have the extension so I didn't check. Happy to install it and test that. Ok if I just test with Chrome, or do you think I should check extensions on other browsers too? |
|
I installed the Chrome LiveReload extension and tested this out. Seemd to work as expected.
I also fired up the network tab in devtools to see if the page gets reloaded twice, or something like that, and didn't see anything fishy. I'm assuming that the live-reload.js that's injected by connect-livereload will not activate if it detects that the livereload extension is already active. |
|
Hey thanks for this! Sorry about the delay. Big delivery at work. I'll try and get to this in the next couple of days. |
|
No need to apologize! You're the one maintaining awesome free software for anyone to use that wants it! |
|
+1, I had problems with live reload working and manually making this change fixed it for me. |
F1LT3R
left a comment
There was a problem hiding this comment.
Look great! Working well. Thanks for submitting this.
Live reload wasn't working for me. I poked around a bit and saw that the
live-reload.jswasn't getting injected into the rendered HTML. Reading the connect-livereload docs it looks like that's because it needs to be inserted in the connect middleware stack before any routes that we want it to inject the live-reload.js into:I tested this locally and it fixed things for me - live-reload wasn't working before, and is now.