Added failing test for reading a DocumentPage#1687
Merged
rjrudin merged 1 commit intodevelopmarklogic/java-client-api:developfrom Jul 30, 2024
feature/multipart-response-refactormarklogic/java-client-api:feature/multipart-response-refactorCopy head branch name to clipboard
Merged
Added failing test for reading a DocumentPage#1687rjrudin merged 1 commit intodevelopmarklogic/java-client-api:developfrom feature/multipart-response-refactormarklogic/java-client-api:feature/multipart-response-refactorCopy head branch name to clipboard
rjrudin merged 1 commit intodevelopmarklogic/java-client-api:developfrom
feature/multipart-response-refactormarklogic/java-client-api:feature/multipart-response-refactorCopy head branch name to clipboard
Conversation
The test is disabled as I'm using it to do some refactoring first and then figure out how to use OkHttp's newish MultipartReader to fix this problem. Other changes: 1. Did some refactoring in `OkHttpServices` to make the code for reading a multipart response easier to read and eventually change to use OkHttp's MultipartReader. 2. Formatted Common and AbstractOpticUpdateTest.
BillFarber
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is disabled as I'm using it to do some refactoring first and then figure out how to use OkHttp's newish MultipartReader to fix this problem.
Other changes:
OkHttpServicesto make the code for reading a multipart response easier to read and eventually change to use OkHttp's MultipartReader.